Use SchemaReflection and BoundSchemaReflection instead of SchemaCache
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoodrow
changed the title
SchemaReflection and BoundSchemaReflection instead of SchemaCacheSchemaReflection and BoundSchemaReflection instead of SchemaCache
| @@ -212,7 +212,12 @@ def initialize(proxy) | |||
| @proxy = proxy | |||
| @owner = nil | |||
| @pool = nil | |||
| @schema_cache = ActiveRecord::ConnectionAdapters::SchemaCache.new @proxy | |||
| if ActiveRecord.version >= Gem::Version.new('7.1.0') | |||
| schema_reflection = ActiveRecord::ConnectionAdapters::SchemaReflection.new(nil).load!(@proxy) | |||
There was a problem hiding this comment.
This still not going to work because you are passing nil to ActiveRecord::ConnectionAdapters::SchemaReflection.new
The right approach would be passing the schema_cache_path to ActiveRecord::ConnectionAdapters::SchemaReflection.new in order to fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7.1 warns that
ActiveRecord::ConnectionAdapters::SchemaCachewill be removed in Rails 7.2.I tried to look around at what was being returned by
ActiveRecord::ConnectionAdapters::SchemaCacheand try to rebuild the exact same class and this seems to work out.Ran the CI on our end and it seems to work if I use the
ActiveRecordversion as a condition for the switch. There's most-likely a better way of doing this if you have suggestions.Solves #382